Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 803733002: Roll PDFium (Closed)

Created:
6 years ago by jam
Modified:
6 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium This brings in: f650510 Fix build after previous commit. 217ecf3 Simplify PDFium by removing code that's not used in the open source repo. 2399550 m_pColorSpace can not be NULL for image object with DCTDecode filter 8695172 Do not do strict check of BitsPerComponent for RunLengthDecode filter 381b911 Lab colorspace needs to be 3 component ca5d769 Trailer should be a dictionary object 4429eaa Replace manual/error-prone/hard-to-verify arraysize calculations with safe FX_ArraySize macro. b69da0b Getting rid of more (FX_LPCWSTR) casts and fixing two bugs revealed by this. 4b87f7b Cleanup: Remove an unused function. df76a19 Add a missing 'using' keyword in big integer library 91dd8c7 Modify big integer library 44047c3 Remove unnecessary files in third_party/bigint 7504b3d Initial check in of big integer library, v2010.04.30 4643533 Update to openjpeg r2944 Committed: https://crrev.com/3df5f766110941db077a2c8281e8107dc67834ed Cr-Commit-Position: refs/heads/master@{#308417}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -44 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdf.cc View 1 2 7 chunks +5 lines, -23 lines 0 comments Download
M pdf/pdf_engine.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 3 3 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
6 years ago (2014-12-15 18:46:02 UTC) #2
Tom Sepez
lgtm
6 years ago (2014-12-15 19:25:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803733002/60001
6 years ago (2014-12-15 20:12:25 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 21:13:20 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 21:14:08 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3df5f766110941db077a2c8281e8107dc67834ed
Cr-Commit-Position: refs/heads/master@{#308417}

Powered by Google App Engine
This is Rietveld 408576698