Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/WebCore/html/HTMLObjectElement.cpp

Issue 8037052: Merge 95204 - 2011-09-15 James Simonsen <simonjam@chromium.org> (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/html/HTMLEmbedElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 bool beforeLoadAllowedLoad = dispatchBeforeLoadEvent(url); 322 bool beforeLoadAllowedLoad = dispatchBeforeLoadEvent(url);
323 m_inBeforeLoadEventHandler = false; 323 m_inBeforeLoadEventHandler = false;
324 324
325 // beforeload events can modify the DOM, potentially causing 325 // beforeload events can modify the DOM, potentially causing
326 // RenderWidget::destroy() to be called. Ensure we haven't been 326 // RenderWidget::destroy() to be called. Ensure we haven't been
327 // destroyed before continuing. 327 // destroyed before continuing.
328 // FIXME: Should this render fallback content? 328 // FIXME: Should this render fallback content?
329 if (!renderer()) 329 if (!renderer())
330 return; 330 return;
331 331
332 RefPtr<HTMLObjectElement> protect(this); // Loading the plugin might remove us from the document.
332 SubframeLoader* loader = document()->frame()->loader()->subframeLoader(); 333 SubframeLoader* loader = document()->frame()->loader()->subframeLoader();
333 bool success = beforeLoadAllowedLoad && hasValidClassId() && loader->request Object(this, url, getAttribute(nameAttr), serviceType, paramNames, paramValues); 334 bool success = beforeLoadAllowedLoad && hasValidClassId() && loader->request Object(this, url, getAttribute(nameAttr), serviceType, paramNames, paramValues);
334 335
335 if (!success && fallbackContent) 336 if (!success && fallbackContent)
336 renderFallbackContent(); 337 renderFallbackContent();
337 } 338 }
338 339
339 bool HTMLObjectElement::rendererIsNeeded(const NodeRenderingContext& context) 340 bool HTMLObjectElement::rendererIsNeeded(const NodeRenderingContext& context)
340 { 341 {
341 // FIXME: This check should not be needed, detached documents never render! 342 // FIXME: This check should not be needed, detached documents never render!
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 { 558 {
558 return m_name.isNull() ? emptyAtom : m_name; 559 return m_name.isNull() ? emptyAtom : m_name;
559 } 560 }
560 561
561 HTMLFormElement* HTMLObjectElement::virtualForm() const 562 HTMLFormElement* HTMLObjectElement::virtualForm() const
562 { 563 {
563 return FormAssociatedElement::form(); 564 return FormAssociatedElement::form();
564 } 565 }
565 566
566 } 567 }
OLDNEW
« no previous file with comments | « Source/WebCore/html/HTMLEmbedElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698