Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 803673003: Delete StyleSheetList and support code. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete StyleSheetList and support code. We don't need this since we don't expose the list of sheets from Document or ShadowRoot in Sky. After removing this code I also simplified the system and deleted StyleSheetCandidate and DocumentStyleSheetCollector which don't really do anything anymore. Even if we do want to add back a list of sheets later it won't need code because we don't have a concept of a remote sheet like <link rel> did, and we don't have to deal with non-CSS sheets. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c177d41b3b416f03c404559d5abca2a6ade333ac

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -514 lines) Patch
M sky/engine/core/core.gni View 3 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/core/css/StyleSheetList.h View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/engine/core/css/StyleSheetList.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.cpp View 2 chunks +10 lines, -17 lines 1 comment Download
D sky/engine/core/dom/DocumentStyleSheetCollector.h View 1 chunk +0 lines, -79 lines 0 comments Download
D sky/engine/core/dom/DocumentStyleSheetCollector.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
M sky/engine/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -5 lines 1 comment Download
M sky/engine/core/dom/StyleEngine.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 3 chunks +7 lines, -9 lines 0 comments Download
D sky/engine/core/dom/StyleSheetCandidate.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/core/dom/StyleSheetCandidate.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-12 23:02:57 UTC) #2
ojan
lgtm https://codereview.chromium.org/803673003/diff/1/sky/engine/core/dom/DocumentStyleSheetCollection.cpp File sky/engine/core/dom/DocumentStyleSheetCollection.cpp (right): https://codereview.chromium.org/803673003/diff/1/sky/engine/core/dom/DocumentStyleSheetCollection.cpp#newcode50 sky/engine/core/dom/DocumentStyleSheetCollection.cpp:50: if (!isHTMLStyleElement(*node)) Nit: This could be an assert. ...
6 years ago (2014-12-12 23:38:39 UTC) #3
esprehn
6 years ago (2014-12-12 23:48:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c177d41b3b416f03c404559d5abca2a6ade333ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698