Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803673002: Autofill: one FormCache per WebFrame. (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: one FormCache per WebFrame. BUG=425756 Committed: https://crrev.com/ff02e6d95dd707892190938f6e2e4d83a23f481a Cr-Commit-Position: refs/heads/master@{#308419}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : better docs #

Total comments: 2

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -150 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 2 3 23 chunks +45 lines, -45 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/form_cache.h View 1 2 3 3 chunks +14 lines, -12 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 2 3 6 chunks +42 lines, -89 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
+vabr because this was a TODO from the OOPIF refactor +thestig because he's been touching ...
6 years ago (2014-12-12 22:09:42 UTC) #2
Lei Zhang
lgtm
6 years ago (2014-12-12 22:48:30 UTC) #3
vabr (Chromium)
LGTM with a nit. Cheers, Vaclav https://codereview.chromium.org/803673002/diff/40001/components/autofill/content/renderer/form_cache.h File components/autofill/content/renderer/form_cache.h (right): https://codereview.chromium.org/803673002/diff/40001/components/autofill/content/renderer/form_cache.h#newcode32 components/autofill/content/renderer/form_cache.h:32: FormCache(const blink::WebFrame& frame); ...
6 years ago (2014-12-15 09:30:13 UTC) #4
Evan Stade
https://codereview.chromium.org/803673002/diff/40001/components/autofill/content/renderer/form_cache.h File components/autofill/content/renderer/form_cache.h (right): https://codereview.chromium.org/803673002/diff/40001/components/autofill/content/renderer/form_cache.h#newcode32 components/autofill/content/renderer/form_cache.h:32: FormCache(const blink::WebFrame& frame); On 2014/12/15 09:30:13, vabr (OOO soon) ...
6 years ago (2014-12-15 18:41:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803673002/60001
6 years ago (2014-12-15 19:25:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 21:18:41 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-15 21:19:31 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ff02e6d95dd707892190938f6e2e4d83a23f481a
Cr-Commit-Position: refs/heads/master@{#308419}

Powered by Google App Engine
This is Rietveld 408576698