Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 803663002: Have SourceBufferList trace all its object references. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Have SourceBufferList trace all its object references. Turn the GenericEventQueue and ExecutionContext fields into Members and trace them also. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187092

Patch Set 1 #

Patch Set 2 : need a transition type still #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/modules/mediasource/SourceBufferList.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/mediasource/SourceBufferList.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
6 years ago (2014-12-13 08:13:30 UTC) #2
haraken
LGTM
6 years ago (2014-12-13 08:42:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803663002/20001
6 years ago (2014-12-13 09:07:19 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-13 09:50:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187092

Powered by Google App Engine
This is Rietveld 408576698