Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: remoting/webapp/crd/js/hangout_session.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused types Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/hangout_session.js
diff --git a/remoting/webapp/crd/js/hangout_session.js b/remoting/webapp/crd/js/hangout_session.js
index 7776f156d57861c4b8bbda3b8d7d6207bf07a78e..32d0200d3de42c596e35bd25e8fd5b301d658012 100644
--- a/remoting/webapp/crd/js/hangout_session.js
+++ b/remoting/webapp/crd/js/hangout_session.js
@@ -43,16 +43,16 @@ remoting.HangoutSession.prototype.init = function() {
};
/**
- * @param {remoting.ClientSession.State} state
+ * @param {remoting.ClientSession.State=} state
*/
remoting.HangoutSession.prototype.onSessionStateChanged_ = function(state) {
var State = remoting.ClientSession.State;
try {
this.port_.postMessage({method: 'sessionStateChanged', state: state});
- } catch (e) {
+ } catch (/** @type {*} */ e) {
kelvinp 2015/01/12 22:51:28 Can we use /** @type {Error} */ e here and get rid
garykac 2015/01/13 00:28:39 Done.
// postMessage will throw an exception if the port is disconnected.
// We can safely ignore this exception.
- var error = /** @type {Error} */ e;
+ var error = /** @type {Error} */ (e);
console.error(error);
} finally {
if (state === State.FAILED || state === State.CLOSED) {
@@ -79,4 +79,4 @@ remoting.hangoutSessionEvents = new base.EventSource();
remoting.hangoutSessionEvents.sessionStateChanged = "sessionStateChanged";
remoting.hangoutSessionEvents.defineEvents(
- [remoting.hangoutSessionEvents.sessionStateChanged]);
+ [remoting.hangoutSessionEvents.sessionStateChanged]);

Powered by Google App Engine
This is Rietveld 408576698