Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: remoting/webapp/base/js/message_window.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused types Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/message_window.js
diff --git a/remoting/webapp/base/js/message_window.js b/remoting/webapp/base/js/message_window.js
index 297373aa658946efb2fbb46ce53335641d2a8491..2355b3e5390af93dd4d3bf3d79dbf4c67be84ad3 100644
--- a/remoting/webapp/base/js/message_window.js
+++ b/remoting/webapp/base/js/message_window.js
@@ -125,15 +125,17 @@ MessageWindowImpl.prototype.onMessage_ = function(event) {
infoboxDiv.hidden = true;
}
+ var messageIdStr = messageId.toString();
+
this.initButton_(
button,
buttonLabel,
- this.sendReply_.bind(this, event.source, messageId, 1));
+ this.sendReply_.bind(this, event.source, messageIdStr, 1));
this.initButton_(
cancelButton,
cancelButtonLabel,
- this.sendReply_.bind(this, event.source, messageId, 0));
+ this.sendReply_.bind(this, event.source, messageIdStr, 0));
var buttonToFocus = (cancelButtonLabel) ? cancelButton : button;
buttonToFocus.focus();
@@ -143,7 +145,7 @@ MessageWindowImpl.prototype.onMessage_ = function(event) {
// Note that when a button is pressed, this will result in sendReply_
// being called multiple times (once for the button, once for close).
chrome.app.window.current().onClosed.addListener(
- this.sendReply_.bind(this, event.source, messageId, 0));
+ this.sendReply_.bind(this, event.source, messageIdStr, 0));
this.updateSize_();
chrome.app.window.current().show();

Powered by Google App Engine
This is Rietveld 408576698