Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: remoting/webapp/crd/js/host_screen.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define Entry for browser_tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/host_screen.js
diff --git a/remoting/webapp/crd/js/host_screen.js b/remoting/webapp/crd/js/host_screen.js
index bf15b17a7a74a388f30bcc1c5dcfd37d710543a4..10304d06723c7ab128ccf18202c7ee25823f779e 100644
--- a/remoting/webapp/crd/js/host_screen.js
+++ b/remoting/webapp/crd/js/host_screen.js
@@ -92,7 +92,7 @@ remoting.tryShareWithToken_ = function(hostFacade, token) {
disableTimeoutCountdown_();
remoting.hostSession = new remoting.HostSession();
- var email = /** @type {string} */remoting.identity.getCachedEmail();
+ var email = /** @type {string} */ (remoting.identity.getCachedEmail());
remoting.hostSession.connect(
hostFacade, email, token, onHostStateChanged_,
onNatTraversalPolicyChanged_, logDebugInfo_, it2meConnectFailed_);
@@ -223,10 +223,8 @@ remoting.cancelShare = function() {
remoting.lastShareWasCancelled = true;
try {
remoting.hostSession.disconnect();
- } catch (error) {
- // Hack to force JSCompiler type-safety.
- var errorTyped = /** @type {{description: string}} */ error;
- console.error('Error disconnecting: ' + errorTyped.description +
+ } catch (/** @type {*} */ error) {
+ console.error('Error disconnecting: ' + error +
'. The host probably crashed.');
// TODO(jamiewalch): Clean this up. We should have a class representing
// the host plugin, like we do for the client, which should handle crash

Powered by Google App Engine
This is Rietveld 408576698