Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: remoting/webapp/crd/js/app_launcher.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define Entry for browser_tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/app_launcher.js
diff --git a/remoting/webapp/crd/js/app_launcher.js b/remoting/webapp/crd/js/app_launcher.js
index b506a6cbbe4fd4a72c7eb97381ef35f495709f83..29589dfc45f6f8d9ba358d02e4d37b5a6cf75be5 100644
--- a/remoting/webapp/crd/js/app_launcher.js
+++ b/remoting/webapp/crd/js/app_launcher.js
@@ -78,7 +78,7 @@ remoting.V1AppLauncher.prototype.close = function(id) {
if (!tab) {
reject(new Error(chrome.runtime.lastError.message));
} else {
- chrome.tabs.remove(tab.id, resolve);
+ chrome.tabs.remove(tab.id, /** @type {function(*=):void} */ (resolve));
}
});
});
@@ -111,7 +111,7 @@ remoting.V2AppLauncher.prototype.launch = function(opt_launchArgs) {
'frame': 'none',
'id': String(remoting.V2AppLauncher.nextWindowId_++)
},
- /** @param {AppWindow} appWindow */
+ /** @param {AppWindow=} appWindow */
function(appWindow) {
if (!appWindow) {
reject(new Error(chrome.runtime.lastError.message));

Powered by Google App Engine
This is Rietveld 408576698