remoting/webapp/app_remoting/js/app_remoting.js - Issue 803653004: Update Chromoting to use /third_party/closure_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Define Entry for browser_tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/remoting_webapp_files.gypi ('k') | remoting/webapp/app_remoting/js/application_context_menu.js » ('j') | third_party/closure_compiler/checker.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/app_remoting/js/app_remoting.js

diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js

index 207ec414200079adfba06ee02a88fb232b35af45..f70c13ec4320550a7b6bfc6ce8c952209bff50f5 100644

--- a/remoting/webapp/app_remoting/js/app_remoting.js

+++ b/remoting/webapp/app_remoting/js/app_remoting.js

@@ -240,7 +240,7 @@ remoting.AppRemoting.prototype.handleConnected = function(clientSession) {

// Cancel the ping when the connection closes.

clientSession.addEventListener(

remoting.ClientSession.Events.stateChanged,

- /** @param {remoting.ClientSession.StateEvent} state */

+ /** @param {remoting.ClientSession.StateEvent=} state */

function(state) {

if (state.current === remoting.ClientSession.State.CLOSED ||

state.current === remoting.ClientSession.State.FAILED) {