remoting/app_remoting_webapp_build.gypi - Issue 803653004: Update Chromoting to use /third_party/closure_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/app_remoting_webapp_build.gypi

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Define Entry for browser_tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/app_remoting_webapp_build.gypi

diff --git a/remoting/app_remoting_webapp_build.gypi b/remoting/app_remoting_webapp_build.gypi

index 3ea39a9650342de2ec9a74d78112d6ad008dbc60..75a88a29ec8490787c8d32f5fa4bc66538ab82b4 100644

--- a/remoting/app_remoting_webapp_build.gypi

+++ b/remoting/app_remoting_webapp_build.gypi

@@ -258,7 +258,6 @@

'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_main_jscompile.stamp',

'inputs': [

- 'tools/jscompile.py',

'<@(ar_main_js_files)',

'<@(remoting_webapp_js_proto_files)',

# Include zip as input so that this action is run after the build.

@@ -268,11 +267,12 @@

'<(success_stamp)',

'action': [

- 'python', 'tools/jscompile.py',

+ 'python', '../third_party/closure_compiler/checker.py',

+ '--strict',

+ '--no-single-file',

+ '--success-stamp', '<(success_stamp)',

'<@(ar_main_js_files)',

'<@(remoting_webapp_js_proto_files)',

- '--success-stamp',

- '<(success_stamp)'

{

@@ -281,7 +281,6 @@

'success_stamp': '<(PRODUCT_DIR)/>(_target_name)_background_jscompile.stamp',

'inputs': [

- 'tools/jscompile.py',

'<@(ar_background_js_files)',

'<@(remoting_webapp_js_proto_files)',

# Include zip as input so that this action is run after the build.

@@ -291,11 +290,12 @@

'<(success_stamp)',

'action': [

- 'python', 'tools/jscompile.py',

+ 'python', '../third_party/closure_compiler/checker.py',

+ '--strict',

+ '--no-single-file',

+ '--success-stamp', '<(success_stamp)',

'<@(ar_background_js_files)',

'<@(remoting_webapp_js_proto_files)',

- '--success-stamp',

- '<(success_stamp)'

], # actions

« no previous file with comments | « no previous file | remoting/remoting_webapp.gypi » ('j') | third_party/closure_compiler/checker.py » ('J')