Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: remoting/webapp/js_proto/chrome_proto.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/js_proto/chrome_proto.js
diff --git a/remoting/webapp/js_proto/chrome_proto.js b/remoting/webapp/js_proto/chrome_proto.js
index d7b1f13738311a6d000c2c117dca8d330704ae24..e3a1df8c5e488df4591983c4eff78ff51fe2ad9e 100644
--- a/remoting/webapp/js_proto/chrome_proto.js
+++ b/remoting/webapp/js_proto/chrome_proto.js
@@ -6,9 +6,6 @@
// WebKit- and Chrome-specific properties and methods. It is used only with
// JSCompiler to verify the type-correctness of our code.
-/** @type {Object} */
-var chrome = {};
-
/** @constructor */
chrome.Event = function() {};
@@ -33,7 +30,7 @@ chrome.app.window = {
/**
* @param {string} name
* @param {Object} parameters
- * @param {function()=} opt_callback
+ * @param {function(AppWindow)=} opt_callback
*/
create: function(name, parameters, opt_callback) {},
/**
@@ -258,12 +255,15 @@ chrome.fileSystem = {
*/
chooseEntry: function(options, callback) {},
/**
- * @param {FileEntry} fileEntry
+ * @param {Entry} entry
* @param {function(string):void} callback
*/
- getDisplayPath: function(fileEntry, callback) {}
+ getDisplayPath: function(entry, callback) {}
};
+/** @param {function(FileWriter):void} callback */
+Entry.prototype.createWriter = function(callback) {};
+
/** @type {Object} */
chrome.identity = {
/**
@@ -319,7 +319,7 @@ chrome.tabs.get = function(id, callback) {};
/**
* @param {string} id
- * @param {function()=} opt_callback
+ * @param {function(*=):void=} opt_callback
*/
chrome.tabs.remove = function(id, opt_callback) {};
@@ -416,22 +416,6 @@ function Bounds() {
this.height = 0;
};
-/** @constructor */
-function ClientRect() {
- /** @type {number} */
- this.width = 0;
- /** @type {number} */
- this.height = 0;
- /** @type {number} */
- this.top = 0;
- /** @type {number} */
- this.bottom = 0;
- /** @type {number} */
- this.left = 0;
- /** @type {number} */
- this.right = 0;
-};
-
/** @type {Object} */
chrome.cast = {};
@@ -507,7 +491,7 @@ chrome.cast.Session.prototype.addUpdateListener = function(listener) {};
/**
* @param {string} namespace
- * @param {function(chrome.cast.media.Media):void} listener
+ * @param {function(string, string):void} listener
*/
chrome.cast.Session.prototype.addMessageListener =
function(namespace, listener){};

Powered by Google App Engine
This is Rietveld 408576698