Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: remoting/webapp/crd/js/it2me_host_facade.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/it2me_host_facade.js
diff --git a/remoting/webapp/crd/js/it2me_host_facade.js b/remoting/webapp/crd/js/it2me_host_facade.js
index eab5ee19cf08dee2940ddc013c08ce535bc95b82..621befb53caf332abc8487ee976f903d0a75d2cd 100644
--- a/remoting/webapp/crd/js/it2me_host_facade.js
+++ b/remoting/webapp/crd/js/it2me_host_facade.js
@@ -67,7 +67,7 @@ remoting.It2MeHostFacade = function() {
/**
* Called if the It2Me Native Messaging host sends a malformed message:
* missing required attributes, attributes with incorrect types, etc.
- * @param {remoting.Error} error
+ * @type {?function(remoting.Error):void}
* @private
*/
this.onError_ = function(error) {};
@@ -91,9 +91,9 @@ remoting.It2MeHostFacade = function() {
* native messaging host is not installed, onInitializationFailed is invoked.
* Otherwise, onInitialized is invoked.
*
- * @param {function():void} onInitialized Called after successful
+ * @param {function(*=):void} onInitialized Called after successful
* initialization.
- * @param {function():void} onInitializationFailed Called if cannot connect to
+ * @param {function(*=):void} onInitializationFailed Called if cannot connect to
* the native messaging host.
* @return {void}
*/
@@ -108,9 +108,8 @@ remoting.It2MeHostFacade.prototype.initialize =
this.port_.onMessage.addListener(this.onIncomingMessage_.bind(this));
this.port_.onDisconnect.addListener(this.onHostDisconnect_.bind(this));
this.port_.postMessage({type: 'hello'});
- } catch (err) {
- console.log('Native Messaging initialization failed: ',
- /** @type {*} */ (err));
+ } catch (/** @type {*} */ err) {
+ console.log('Native Messaging initialization failed: ', err);
onInitializationFailed();
return;
}

Powered by Google App Engine
This is Rietveld 408576698