Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: remoting/webapp/crd/js/host_controller.js

Issue 803653004: Update Chromoting to use /third_party/closure_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/host_controller.js
diff --git a/remoting/webapp/crd/js/host_controller.js b/remoting/webapp/crd/js/host_controller.js
index 2eef2a506cc3b82d1cd0eeb19133a0368fb5026e..35de748b343ae9ca585128794c3e9ef8cc595366 100644
--- a/remoting/webapp/crd/js/host_controller.js
+++ b/remoting/webapp/crd/js/host_controller.js
@@ -133,7 +133,7 @@ remoting.HostController.prototype.start = function(hostPin, consent, onDone,
/** @type {Array.<string>} */
var e = new Array();
for (var i = 0; i < 8; i++) {
- e[i] = (/** @type {number} */random[i] + 0x10000).
+ e[i] = (/** @type {number} */ (random[i]) + 0x10000).
toString(16).substring(1);
}
return e[0] + e[1] + '-' + e[2] + '-' + e[3] + '-' +
@@ -169,9 +169,9 @@ remoting.HostController.prototype.start = function(hostPin, consent, onDone,
* @param {string} hostName
* @param {string} publicKey
* @param {string} privateKey
- * @param {string} xmppLogin
- * @param {string} refreshToken
- * @param {string} clientBaseJid
+ * @param {?string} xmppLogin
+ * @param {?string} refreshToken
+ * @param {?string} clientBaseJid
* @param {string} hostSecretHash
*/
function startHostWithHash(hostName, publicKey, privateKey, xmppLogin,
@@ -268,7 +268,7 @@ remoting.HostController.prototype.start = function(hostPin, consent, onDone,
* @param {string} hostName
* @param {string} privateKey
* @param {string} publicKey
- * @param {string} hostClientId
+ * @param {?string} hostClientId
* @param {string} oauthToken
*/
function doRegisterHost(
@@ -474,7 +474,7 @@ remoting.HostController.prototype.getLocalHostId = function(onDone) {
function onConfig(config) {
var hostId = null;
if (isHostConfigValid_(config)) {
- hostId = /** @type {string} */ config['host_id'];
+ hostId = /** @type {string} */ (config['host_id']);
}
onDone(hostId);
};

Powered by Google App Engine
This is Rietveld 408576698