Update Chromoting to use /third_party/closure_compiler.

remoting/webapp/crd/js/host_daemon_facade.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class to communicate with the host daemon via Native Messaging.
  */
 
 'use strict';
@@ skipping 73 matching lines @@
 };
 
 /**
  * Connects to the native messaging host and sends a hello message.
  *
  * @return {Promise} A promise that fulfills when the connection attempt
  *     succeeds or fails.
  * @private
  */
 remoting.HostDaemonFacade.prototype.connectNative_ = function() {
-  return new Promise(
-    /**
-     * @param {function(*=):void} resolve
-     * @param {function(*=):void} reject
-     * @this {remoting.HostDaemonFacade}
-     */
-    function(resolve, reject) {
-      try {
-        this.port_ = chrome.runtime.connectNative(
-            'com.google.chrome.remote_desktop');
-        this.port_.onMessage.addListener(this.onIncomingMessageCallback_);
-        this.port_.onDisconnect.addListener(this.onDisconnectCallback_);
-        this.postMessageInternal_({type: 'hello'}, resolve, reject);
-      } catch (err) {
-        console.log('Native Messaging initialization failed: ',
-                    /** @type {*} */ (err));
-        reject();
-      }
-    }.bind(this)
-  );
+  /**
+   * @this {remoting.HostDaemonFacade}
+   * @param {function(?):void} resolve
+   * @param {function(*):void} reject
+   */
+  var connect = function(resolve, reject) {
+    try {
+      this.port_ = chrome.runtime.connectNative(
+          'com.google.chrome.remote_desktop');
+      this.port_.onMessage.addListener(this.onIncomingMessageCallback_);
+      this.port_.onDisconnect.addListener(this.onDisconnectCallback_);
+      this.postMessageInternal_({type: 'hello'}, resolve, reject);
+    } catch (/** @type {*} */ err) {
+      console.log('Native Messaging initialization failed: ', err);
+      reject(false);

[kelvinp, 2015/01/12 22:51:28]

why false here?

[garykac, 2015/01/13 00:28:39]

reject() requires at least 1 argument(s) and no more than 1 argument(s)

The value 'false' is arbitrary, but it seemed better than true. Is something
like '0' better here?

[Tyler Breisacher (Chromium), 2015/01/13 03:01:00]

We actually changed this in
https://github.com/google/closure-compiler/commit/921c464b40f3068f17c4c8ab017...
so you could probably remove the 'false' (or null or whatever you decide to
pass) after the next time you bump the compiler version.

+    }
+  };
+
+  return new Promise(connect.bind(this));
 };
 
 /**
  * Type used for entries of |pendingReplies_| list.
  *
  * @param {string} type Type of the originating request.
  * @param {function(...):void} onDone Response callback. Parameters depend on
  *     the request type.
  * @param {function(remoting.Error):void} onError Callback to call on error.
  * @constructor
@@ skipping 82 matching lines @@
   }
   delete this.pendingReplies_[id];
 
   try {
     var type = getStringAttr(message, 'type');
     if (type != reply.type) {
       throw 'Expected reply type: ' + reply.type + ', got: ' + type;
     }
 
     this.handleIncomingMessage_(message, reply.onDone);
-  } catch (e) {
-    console.error('Error while processing native message' +
-                  /** @type {*} */ (e));
+  } catch (/** @type {*} */ e) {
+    console.error('Error while processing native message' + e);
     reply.onError(remoting.Error.UNEXPECTED);
   }
 }
 
 /**
  * Handler for incoming Native Messages.
  *
  * @param {Object} message The received message.
  * @param {function(...):void} onDone Function to call when we're done
  *     processing the message.
@@ skipping 104 matching lines @@
 
   // If initialization hasn't finished then assume that the port was
   // disconnected because Native Messaging host is not installed.
   this.error_ = this.initializingPromise_ ? remoting.Error.MISSING_PLUGIN :
                                             remoting.Error.UNEXPECTED;
 
   // Notify the error-handlers of any requests that are still outstanding.
   var pendingReplies = this.pendingReplies_;
   this.pendingReplies_ = {};
   for (var id in pendingReplies) {
-    pendingReplies[/** @type {number} */(id)].onError(this.error_);
+    var num_id = parseInt(id, 10);
+    pendingReplies[num_id].onError(this.error_);
   }
 }
 
 /**
  * Gets local hostname.
  *
  * @param {function(string):void} onDone Callback to return result.
  * @param {function(remoting.Error):void} onError Callback to call on error.
  * @return {void} Nothing.
  */
@@ skipping 205 matching lines @@
  * @param {function(remoting.Error):void} onError Callback to call on error.
  * @return {void} Nothing.
  */
 remoting.HostDaemonFacade.prototype.getCredentialsFromAuthCode =
     function(authorizationCode, onDone, onError) {
   this.postMessage_({
     type: 'getCredentialsFromAuthCode',
     authorizationCode: authorizationCode
   }, onDone, onError);
 };