Update Chromoting to use /third_party/closure_compiler.

remoting/webapp/crd/js/ui_mode.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to controlling the modal UI state of the app. UI states
  * are expressed as HTML attributes with a dotted hierarchy. For example, the
  * string 'host.shared' will match any elements with an associated attribute
  * of 'host' or 'host.shared', showing those elements and hiding all others.
@@ skipping 70 matching lines @@
  * @return {void} Nothing.
  */
 remoting.updateModalUi = function(mode, attr) {
   var modes = mode.split('.');
   for (var i = 1; i < modes.length; ++i)
     modes[i] = modes[i - 1] + '.' + modes[i];
   var elements = document.querySelectorAll('[' + attr + ']');
   // Hide elements first so that we don't end up trying to show two modal
   // dialogs at once (which would break keyboard-navigation confinement).
   for (var i = 0; i < elements.length; ++i) {
-    var element = /** @type {Element} */ elements[i];
+    var element = /** @type {Element} */ (elements[i]);
     if (!remoting.hasModeAttribute(element, attr, modes)) {
       element.hidden = true;
     }
   }
   for (var i = 0; i < elements.length; ++i) {
-    var element = /** @type {Element} */ elements[i];
+    var element = /** @type {Element} */ (elements[i]);
     if (remoting.hasModeAttribute(element, attr, modes)) {
       element.hidden = false;
       var autofocusNode = element.querySelector('[autofocus]');
       if (autofocusNode) {
         autofocusNode.focus();
       }
     }
   }
 };
 
@@ skipping 47 matching lines @@
  */
 remoting.getMajorMode = function() {
   return remoting.currentMode.split('.')[0];
 };
 
 /**
  * Helper function for showing or hiding the infographic UI based on
  * whether or not the user has already dismissed it.
  *
  * @param {string} mode
- * @param {!Object} items
+ * @param {Object<?,string>} items
  */
 remoting.showOrHideCallback = function(mode, items) {
   // Get the first element of a dictionary or array, without needing to know
   // the key.
+  var obj = /** @type {!Object} */(items);
   /** @type {string} */
-  var key = Object.keys(items)[0];
+  var key = Object.keys(obj)[0];
   var visited = !!items[key];
   document.getElementById(mode + '-first-run').hidden = visited;
   document.getElementById(mode + '-content').hidden = !visited;
 };
 
+/**
+ * @param {Object<?,string>} items
+ */
+remoting.showOrHideCallbackIT2Me = function(items) {
+  remoting.showOrHideCallback('it2me', items);
+}
+
+/**
+ * @param {Object<?,string>} items
+ */
+remoting.showOrHideCallbackMe2Me = function(items) {
+  remoting.showOrHideCallback('me2me', items);
+}
+
 remoting.showOrHideIT2MeUi = function() {
   chrome.storage.local.get(remoting.kIT2MeVisitedStorageKey,
-                           remoting.showOrHideCallback.bind(null, 'it2me'));
+                           remoting.showOrHideCallbackIT2Me);

[garykac, 2015/01/12 20:22:37]

It had trouble with the bind, so this removes the need for the bind by breaking
it into 2 separate functions.

 };
 
 remoting.showOrHideMe2MeUi = function() {
   chrome.storage.local.get(remoting.kMe2MeVisitedStorageKey,
-                           remoting.showOrHideCallback.bind(null, 'me2me'));
+                           remoting.showOrHideCallbackMe2Me);
 };
 
 remoting.showIT2MeUiAndSave = function() {
   var items = {};
   items[remoting.kIT2MeVisitedStorageKey] = true;
   chrome.storage.local.set(items);
   remoting.showOrHideCallback('it2me', [true]);
 };
 
 remoting.showMe2MeUiAndSave = function() {
@@ skipping 12 matching lines @@
 
 
 /**
  * Initialize all modal dialogs (class kd-modaldialog), adding event handlers
  * to confine keyboard navigation to child controls of the dialog when it is
  * shown and restore keyboard navigation when it is hidden.
  */
 remoting.initModalDialogs = function() {
   var dialogs = document.querySelectorAll('.kd-modaldialog');
   var observer = new MutationObserver(confineOrRestoreFocus_);
-  var options = {
+  var options = /** @type {MutationObserverInit} */({
     subtree: false,
     attributes: true
-  };
+  });
   for (var i = 0; i < dialogs.length; ++i) {
     observer.observe(dialogs[i], options);
   }
 };
 
 /**
  * @param {Array.<MutationRecord>} mutations The set of mutations affecting
  *     an observed node.
  */
 function confineOrRestoreFocus_(mutations) {
   // The list of mutations can include duplicates, so reduce it to a canonical
   // show/hide list.
-  /** @type {Array.<Element>} */
+  /** @type {Array.<Node>} */
   var shown = [];
-  /** @type {Array.<Element>} */
+  /** @type {Array.<Node>} */
   var hidden = [];
   for (var i = 0; i < mutations.length; ++i) {
     var mutation = mutations[i];
     if (mutation.type == 'attributes' &&
         mutation.attributeName == 'hidden') {
       var node = mutation.target;
       if (node.hidden && hidden.indexOf(node) == -1) {
         hidden.push(node);
       } else if (!node.hidden && shown.indexOf(node) == -1) {
         shown.push(node);
       }
     }
   }
   var kSavedAttributeName = 'data-saved-tab-index';
   // If any dialogs have been dismissed, restore all the tabIndex attributes.
   if (hidden.length != 0) {
     var elements = document.querySelectorAll('[' + kSavedAttributeName + ']');
     for (var i = 0 ; i < elements.length; ++i) {
-      var element = /** @type {Element} */ elements[i];
+      var element = /** @type {Element} */ (elements[i]);
       element.tabIndex = element.getAttribute(kSavedAttributeName);
       element.removeAttribute(kSavedAttributeName);
     }
   }
   // If any dialogs have been shown, confine keyboard navigation to the first
   // one. We don't have nested modal dialogs, so this will suffice for now.
   if (shown.length != 0) {
     var selector = '[tabIndex],a,area,button,input,select,textarea';
     var disable = document.querySelectorAll(selector);
     var except = shown[0].querySelectorAll(selector);
     for (var i = 0; i < disable.length; ++i) {
-      var element = /** @type {Element} */ disable[i];
+      var element = /** @type {Element} */ (disable[i]);
       var removeFromKeyboardNavigation = true;
       for (var j = 0; j < except.length; ++j) {  // No indexOf on NodeList
         if (element == except[j]) {
           removeFromKeyboardNavigation = false;
           break;
         }
       }
       if (removeFromKeyboardNavigation) {
         element.setAttribute(kSavedAttributeName, element.tabIndex);
         element.tabIndex = -1;
       }
     }
   }
 }
 
 /**
  * @param {string} tag
  */
 remoting.showSetupProcessingMessage = function(tag) {
   var messageDiv = document.getElementById('host-setup-processing-message');
   l10n.localizeElementFromTag(messageDiv, tag);
   remoting.setMode(remoting.AppMode.HOST_SETUP_PROCESSING);
 }