Update Chromoting to use /third_party/closure_compiler.

remoting/webapp/base/js/base.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A module that contains basic utility components and methods for the
  * chromoting project
  *
  */
@@ skipping 28 matching lines @@
     }
   }
 };
 
 /**
  * @return {string} The callstack of the current method.
  */
 base.debug.callstack = function() {
   try {
     throw new Error();
-  } catch (e) {
-    var error = /** @type {Error} */ e;
+  } catch (/** @type {*} */ e) {
+    var error = /** @type {Error} */ (e);
     var callstack = error.stack
       .replace(/^\s+(at eval )?at\s+/gm, '') // Remove 'at' and indentation.
       .split('\n');
     callstack.splice(0,2); // Remove the stack of the current function.
   }
   return callstack.join('\n');
 };
 
 /**
   * @interface
@@ skipping 23 matching lines @@
       base.debug.assert(!dest.hasOwnProperty(prop),"Don't override properties");
       dest[prop] = src[prop];
     }
   }
 };
 
 /**
  * Adds a mixin to a class.
  * @param {Object} dest
  * @param {Object} src
- * @suppress {checkTypes}
+ * @suppress {checkTypes|reportUnknownTypes}
  */
 base.extend = function(dest, src) {
   base.mix(dest.prototype, src.prototype || src);
 };
 
 base.doNothing = function() {};
 
 /**
  * Returns an array containing the values of |dict|.
  * @param {!Object} dict
@@ skipping 83 matching lines @@
  *    window.setTimeout(function() {
  *      deferred.resolve();
  *    }, 100);
  *    return deferred.promise();
  *  };
  *
  * @constructor
  */
 base.Deferred = function() {
   /**
-   * @type {?function(?=)}
+   * @type {?function(?):void}
    * @private
    */
   this.resolve_ = null;
 
   /**
-   * @type {?function(?)}
+   * @type {?function(?):void}
    * @private
    */
   this.reject_ = null;
 
   /**
+   * @this {base.Deferred}
+   * @param {function(?):void} resolve
+   * @param {function(*):void} reject
+   */
+  var recordPromise = function(resolve, reject) {

[garykac, 2015/01/12 20:22:37]

Hoisted here because @this doesn't seem to work for inline functions.

+    this.resolve_ = resolve;
+    this.reject_ = reject;
+  };
+
+  /**
    * @type {Promise}
    * @private
    */
-  this.promise_ = new Promise(
-    /**
-     * @param {function(?=):void} resolve
-     * @param {function(?):void} reject
-     * @this {base.Deferred}
-     */
-    function(resolve, reject) {
-      this.resolve_ = resolve;
-      this.reject_ = reject;
-    }.bind(this)
-  );
+  this.promise_ = new Promise(recordPromise.bind(this));
 };
 
 /** @param {*} reason */
 base.Deferred.prototype.reject = function(reason) {
   this.reject_(reason);
 };
 
 /** @param {*=} opt_value */
 base.Deferred.prototype.resolve = function(opt_value) {
   this.resolve_(opt_value);
 };
 
 /** @return {Promise} */
 base.Deferred.prototype.promise = function() {
   return this.promise_;
 };
 
 base.Promise = function() {};
 
 /**
  * @param {number} delay
  * @return {Promise} a Promise that will be fulfilled after |delay| ms.
  */
 base.Promise.sleep = function(delay) {
   return new Promise(
-    /** @param {function():void} fulfill */
+    /** @param {function(*):void} fulfill */
     function(fulfill) {
       window.setTimeout(fulfill, delay);
     });
 };
 
 
 /**
  * @param {Promise} promise
  * @return {Promise} a Promise that will be fulfilled iff the specified Promise
  *     is rejected.
@@ skipping 169 matching lines @@
  * @return {string} A URL-Safe Base64-encoded 128-bit random value. */
 base.generateXsrfToken = function() {
   var random = new Uint8Array(16);
   window.crypto.getRandomValues(random);
   var base64Token = window.btoa(String.fromCharCode.apply(null, random));
   return base64Token.replace(/\+/g, '-').replace(/\//g, '_').replace(/=/g, '');
 };
 
 /**
  * @param {string} jsonString A JSON-encoded string.
- * @return {*} The decoded object, or undefined if the string cannot be parsed.
+ * @return {Object|undefined} The decoded object, or undefined if the string
+ *     cannot be parsed.
  */
 base.jsonParseSafe = function(jsonString) {
   try {
-    return JSON.parse(jsonString);
+    return /** @type {Object} */ (JSON.parse(jsonString));
   } catch (err) {
     return undefined;
   }
 }