Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 803613002: [Extensions Toolbar Mac] Allow the overflow toolbar to use the theme provider (Closed)

Created:
6 years ago by Devlin
Modified:
6 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Allow the overflow toolbar to use the theme provider The overflow menu icons previously didn't have any images because there isn't a theme provider for the menu's window. Allow image cells to provide a different theme provider so these can display properly. BUG=429810 Committed: https://crrev.com/72b4a2c50bf2bc01751aa5a98494bd943955a216 Cr-Commit-Position: refs/heads/master@{#308401}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.mm View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
Avi, please take a look when you can.
6 years ago (2014-12-15 19:32:22 UTC) #4
Avi (use Gerrit)
lgtm
6 years ago (2014-12-15 19:41:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803613002/40001
6 years ago (2014-12-15 19:43:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years ago (2014-12-15 19:59:59 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-15 20:01:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72b4a2c50bf2bc01751aa5a98494bd943955a216
Cr-Commit-Position: refs/heads/master@{#308401}

Powered by Google App Engine
This is Rietveld 408576698