Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: Source/WebCore/dom/Document.cpp

Issue 8036034: Merge 95959 - Delete retired custom font data only on document (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/text/custom-font-data-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * 10 *
(...skipping 1512 matching lines...) Expand 10 before | Expand all | Expand 10 after
1523 RefPtr<RenderStyle> documentStyle = CSSStyleSelector::styleForDocument(t his); 1523 RefPtr<RenderStyle> documentStyle = CSSStyleSelector::styleForDocument(t his);
1524 StyleChange ch = diff(documentStyle.get(), renderer()->style()); 1524 StyleChange ch = diff(documentStyle.get(), renderer()->style());
1525 if (ch != NoChange) 1525 if (ch != NoChange)
1526 renderer()->setStyle(documentStyle.release()); 1526 renderer()->setStyle(documentStyle.release());
1527 } 1527 }
1528 1528
1529 for (Node* n = firstChild(); n; n = n->nextSibling()) 1529 for (Node* n = firstChild(); n; n = n->nextSibling())
1530 if (change >= Inherit || n->childNeedsStyleRecalc() || n->needsStyleReca lc()) 1530 if (change >= Inherit || n->childNeedsStyleRecalc() || n->needsStyleReca lc())
1531 n->recalcStyle(change); 1531 n->recalcStyle(change);
1532 1532
1533 // FIXME: Disabling the deletion of retired custom font data until
1534 // we fix all the stale style bugs (68804, 68624, etc). These bugs
1535 // indicate problems where some styles were not updated in recalcStyle,
1536 // thereby retaining stale copy of font data. To prevent that, we
1537 // disable this code for now and only delete retired custom font data
1538 // in Document destructor.
1533 // Now that all RenderStyles that pointed to retired fonts have been updated , the fonts can safely be deleted. 1539 // Now that all RenderStyles that pointed to retired fonts have been updated , the fonts can safely be deleted.
1534 deleteRetiredCustomFonts(); 1540 // deleteRetiredCustomFonts();
1535 1541
1536 #if USE(ACCELERATED_COMPOSITING) 1542 #if USE(ACCELERATED_COMPOSITING)
1537 if (view()) { 1543 if (view()) {
1538 bool layoutPending = view()->layoutPending() || renderer()->needsLayout( ); 1544 bool layoutPending = view()->layoutPending() || renderer()->needsLayout( );
1539 // If we didn't update compositing layers because of layout(), we need t o do so here. 1545 // If we didn't update compositing layers because of layout(), we need t o do so here.
1540 if (!layoutPending) 1546 if (!layoutPending)
1541 view()->updateCompositingLayers(); 1547 view()->updateCompositingLayers();
1542 } 1548 }
1543 #endif 1549 #endif
1544 1550
(...skipping 3545 matching lines...) Expand 10 before | Expand all | Expand 10 after
5090 if (!loader) 5096 if (!loader)
5091 return 0; 5097 return 0;
5092 5098
5093 if (m_frame->document() != this) 5099 if (m_frame->document() != this)
5094 return 0; 5100 return 0;
5095 5101
5096 return loader; 5102 return loader;
5097 } 5103 }
5098 5104
5099 } // namespace WebCore 5105 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/text/custom-font-data-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698