Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: build/get_landmines.py

Issue 803603003: Turn on clang check for WeakPtrFactory member order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/get_landmines.py
diff --git a/build/get_landmines.py b/build/get_landmines.py
index 74d95616b3c602e6e0ff8d8ce91983104193ef21..c99a0c1a67c2e81e4b507c16c4ffd0d502774689 100755
--- a/build/get_landmines.py
+++ b/build/get_landmines.py
@@ -63,6 +63,7 @@ def print_landmines():
print 'Clobber to delete incompatible object binary format with NDK r10c'
print 'Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).'
print 'Another clobber for missing NaCl gyp deps (crbug.com/427427).'
+ print 'Enabling WeakPtrFactory clang checker (crbug.com/303818).'
Nico 2014/12/18 03:17:42 No need for this: ninja tracks if the command line
def main():
« no previous file with comments | « no previous file | tools/clang/scripts/plugin_flags.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698