Turn on clang check for WeakPtrFactory member order

Turn on clang check for WeakPtrFactory member order

Note that class templates are currently ignored by all Chromium checkers; see crbug.com/441916.

BUG=303818
Committed: https://crrev.com/16a7f5867f76aff97bba8d85996f380161f89673
Cr-Commit-Position: refs/heads/master@{#311770}

[dmichael (off chromium), 2014-12-17 20:52:10]

dmichael@chromium.org changed reviewers:
+ thakis@chromium.org

[dmichael (off chromium), 2014-12-17 20:53:28]

I have a patch up for the one that's failing (just introduced today):
https://codereview.chromium.org/809133002/
I'll wait for that before pushing the button...the landmines change should
ensure that we're clean if this passes CQ.

[Nico, 2014-12-18 03:17:42]

https://codereview.chromium.org/803603003/diff/20001/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/803603003/diff/20001/build/get_landmines.py#n...
build/get_landmines.py:66: print 'Enabling WeakPtrFactory clang checker
(crbug.com/303818).'
No need for this: ninja tracks if the command line of a build edge changes and
reruns it if so. You're adding compiler flags, so all compile command lines will
change and everything will Just Work.

(Every line in this file is a bug in our build system. In an ideal world,
clobbers should never be necessary.)

[Nico, 2014-12-18 03:18:06]

lgtm without the landmine

[Nico, 2014-12-18 03:18:07]

lgtm

lgtm without the landmine

[dmichael (off chromium), 2014-12-19 18:14:47]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-12-19 18:15:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/60001

[commit-bot: I haz the power, 2014-12-19 18:24:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 18:24:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmichael (off chromium), 2014-12-19 18:27:40]

Patchset #3 (id:40001) has been deleted

[dmichael (off chromium), 2014-12-19 18:27:46]

Patchset #3 (id:60001) has been deleted

[dmichael (off chromium), 2014-12-19 18:28:02]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-12-19 18:29:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/80001

[commit-bot: I haz the power, 2014-12-19 19:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 19:33:18]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[dmichael (off chromium), 2014-12-19 21:46:40]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-12-19 21:48:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/80001

[commit-bot: I haz the power, 2014-12-19 22:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-19 22:38:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmichael (off chromium), 2014-12-19 23:02:34]

Patchset #4 (id:100001) has been deleted

[dmichael (off chromium), 2015-01-08 23:40:42]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-01-08 23:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/140001

[commit-bot: I haz the power, 2015-01-08 23:50:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 23:50:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmichael (off chromium), 2015-01-14 18:20:52]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-01-14 18:21:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/260001

[commit-bot: I haz the power, 2015-01-14 18:54:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/260001

[commit-bot: I haz the power, 2015-01-14 20:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 20:26:44]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[dmichael (off chromium), 2015-01-14 20:52:27]

Patchset #10 (id:240001) has been deleted

[dmichael (off chromium), 2015-01-14 22:50:46]

Patchset #11 (id:280001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:06]

Patchset #6 (id:160001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:13]

Patchset #6 (id:180001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:22]

Patchset #6 (id:200001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:29]

Patchset #6 (id:220001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:37]

Patchset #6 (id:260001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:44]

Patchset #6 (id:300001) has been deleted

[dmichael (off chromium), 2015-01-14 22:51:59]

Patchset #5 (id:140001) has been deleted

[dmichael (off chromium), 2015-01-14 22:52:05]

Patchset #4 (id:120001) has been deleted

[dmichael (off chromium), 2015-01-15 18:53:27]

Patchset #7 (id:380001) has been deleted

[dmichael (off chromium), 2015-01-15 20:03:12]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-01-15 20:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803603003/400001

[commit-bot: I haz the power, 2015-01-16 00:28:13]

Committed patchset #7 (id:400001)

[commit-bot: I haz the power, 2015-01-16 00:29:03]

Patchset 7 (id:??) landed as
https://crrev.com/16a7f5867f76aff97bba8d85996f380161f89673
Cr-Commit-Position: refs/heads/master@{#311770}