Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 803603002: android: Remove TraceEvent.begin()/end() (Closed)

Created:
6 years ago by boliu
Modified:
6 years ago
Reviewers:
nyquist
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove TraceEvent.begin()/end() All callers have been moved to onens with explicit event names. Removing the expensive dumping stack implemntation. BUG=439118 Committed: https://crrev.com/8e5c0b0f824d35e369d5db10f0c131d12b5e95a3 Cr-Commit-Position: refs/heads/master@{#308356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M base/android/java/src/org/chromium/base/TraceEvent.java View 3 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
Weee, it's gone!
6 years ago (2014-12-12 18:58:03 UTC) #2
nyquist
lgtm \o/
6 years ago (2014-12-15 09:33:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803603002/1
6 years ago (2014-12-15 15:12:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 16:03:37 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 16:04:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e5c0b0f824d35e369d5db10f0c131d12b5e95a3
Cr-Commit-Position: refs/heads/master@{#308356}

Powered by Google App Engine
This is Rietveld 408576698