Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 803573002: Add a launcher script for the mojo shell on android. (Closed)

Created:
6 years ago by qsr
Modified:
6 years ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add a launcher script for the mojo shell on android. This script will: - Setup port forwarding. - Start a local webserver. - Start the mojo_shell on the android device forwarding its arguments. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/04a2a9caab869347754dc11e142adc60aeaff098

Patch Set 1 #

Patch Set 2 : Style fixes #

Total comments: 3

Patch Set 3 : Follow review #

Patch Set 4 : Follow review #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -0 lines) Patch
A mojo/tools/android_mojo_shell.py View 1 2 3 1 chunk +128 lines, -0 lines 6 comments Download

Messages

Total messages: 8 (1 generated)
qsr
6 years ago (2014-12-12 17:07:03 UTC) #2
sky
https://codereview.chromium.org/803573002/diff/20001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/803573002/diff/20001/mojo/tools/android_mojo_shell.py#newcode18 mojo/tools/android_mojo_shell.py:18: paths = Paths(Config(target_os=Config.OS_ANDROID)) Don't you need to support build ...
6 years ago (2014-12-12 17:54:08 UTC) #3
qsr
https://codereview.chromium.org/803573002/diff/20001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/803573002/diff/20001/mojo/tools/android_mojo_shell.py#newcode75 mojo/tools/android_mojo_shell.py:75: url = None On 2014/12/12 17:54:07, sky wrote: > ...
6 years ago (2014-12-15 14:11:22 UTC) #4
sky
https://codereview.chromium.org/803573002/diff/60001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/803573002/diff/60001/mojo/tools/android_mojo_shell.py#newcode33 mojo/tools/android_mojo_shell.py:33: "[--args-for=<mojo-app>] " You don't have --debug/--release here. https://codereview.chromium.org/803573002/diff/60001/mojo/tools/android_mojo_shell.py#newcode34 mojo/tools/android_mojo_shell.py:34: ...
6 years ago (2014-12-15 17:13:31 UTC) #5
qsr
https://codereview.chromium.org/803573002/diff/60001/mojo/tools/android_mojo_shell.py File mojo/tools/android_mojo_shell.py (right): https://codereview.chromium.org/803573002/diff/60001/mojo/tools/android_mojo_shell.py#newcode33 mojo/tools/android_mojo_shell.py:33: "[--args-for=<mojo-app>] " On 2014/12/15 17:13:31, sky wrote: > You ...
6 years ago (2014-12-15 17:20:13 UTC) #6
sky
Ok, LGTM
6 years ago (2014-12-15 17:52:55 UTC) #7
qsr
6 years ago (2014-12-16 09:31:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
04a2a9caab869347754dc11e142adc60aeaff098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698