Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: content/common/platform_notification_messages.h

Issue 803523002: Remove a renderer -> browser roundtrip for resolving the showNotification promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-rename-params
Patch Set: remove blank link Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/platform_notification_messages.h
diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h
index a0d63908136fb8d89045c5bbd295886474e105a9..96358e838a6b3591a6e93370595a98e1a89bde8e 100644
--- a/content/common/platform_notification_messages.h
+++ b/content/common/platform_notification_messages.h
@@ -30,11 +30,6 @@ IPC_STRUCT_TRAITS_END()
// Messages sent from the browser to the renderer.
-// Informs the renderer that the browser has displayed the persistent
-// notification.
-IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidShowPersistent,
- int /* request_id */)
-
// Informs the renderer that the browser has displayed the notification.
IPC_MESSAGE_CONTROL1(PlatformNotificationMsg_DidShow,
int /* notification_id */)
@@ -55,8 +50,7 @@ IPC_MESSAGE_CONTROL4(PlatformNotificationHostMsg_Show,
SkBitmap /* icon */,
content::PlatformNotificationData /* notification_data */)
-IPC_MESSAGE_CONTROL5(PlatformNotificationHostMsg_ShowPersistent,
- int /* request_id */,
+IPC_MESSAGE_CONTROL4(PlatformNotificationHostMsg_ShowPersistent,
int64 /* service_worker_provider_id */,
GURL /* origin */,
SkBitmap /* icon */,
« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698