Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: Source/platform/heap/Heap.cpp

Issue 803443002: Introduce InlinedGlobalMarkingVisitor Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Heap.h ('k') | Source/platform/heap/Visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Heap.cpp
diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp
index 96a3bebd1d58c422fb5e370da5f9d2f6b4f04d60..20ee685cf7633dbe8551158ad2c9f617f79a13fe 100644
--- a/Source/platform/heap/Heap.cpp
+++ b/Source/platform/heap/Heap.cpp
@@ -450,21 +450,6 @@ private:
};
NO_SANITIZE_ADDRESS inline
-bool HeapObjectHeader::isMarked() const
-{
- checkHeader();
- return m_size & markBitMask;
-}
-
-NO_SANITIZE_ADDRESS inline
-void HeapObjectHeader::mark()
-{
- checkHeader();
- ASSERT(!isMarked());
- m_size = m_size | markBitMask;
-}
-
-NO_SANITIZE_ADDRESS inline
void HeapObjectHeader::unmark()
{
checkHeader();
@@ -2027,6 +2012,12 @@ public:
Heap::pushTraceCallback(m_markingStack, const_cast<void*>(objectPointer), callback);
}
+ virtual void pushTraceCallback(void* objectPointer, TraceCallback callback)
+ {
+ ASSERT(callback);
+ Heap::pushTraceCallback(m_markingStack, objectPointer, callback);
+ }
+
// We need both HeapObjectHeader and GeneralHeapObjectHeader versions to
// correctly find the payload.
virtual void mark(HeapObjectHeader* header, TraceCallback callback) override
@@ -2253,6 +2244,8 @@ public:
return page->terminating();
}
+ virtual bool isGlobalMarkingVisitor() override { return Mode == GlobalMarking; }
+
protected:
virtual void registerWeakCell(void** cell, WeakPointerCallback callback) override
{
« no previous file with comments | « Source/platform/heap/Heap.h ('k') | Source/platform/heap/Visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698