components/autofill/content/renderer/password_autofill_agent.cc - Issue 803353002: Fix to a comment in the password manager fill on account select code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 803353002: Fix to a comment in the password manager fill on account select code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index bbd400a5fe31b24dc2dac421517310679dc35ff0..cebdf38c438845d2ca82186ec7d40a9bbf956c12 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -425,7 +425,7 @@ bool FillFormOnPasswordReceived(

// If (a) is true but (b) is false, then just mark the username element as

// autofilled and return so the fill step is skipped.

- // If (a) is false but (b) is true, then the username element should not be

+ // If (a) and (b) are false, then the username element should not be

// autofilled, but the user should still be able to select to fill the

// password element, so the password element must be marked as autofilled and

// the fill step should also be skipped.

« no previous file with comments | « no previous file | no next file » | no next file with comments »