Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 803343002: [Android] Add UMA for pull-to-refresh activation (Closed)

Created:
6 years ago by jdduke (slow)
Modified:
6 years ago
Reviewers:
Ted C, Ilya Sherman
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add UMA for pull-to-refresh activation Add a baseline metric for the number of page reloads triggered by the new pull-to-refresh gesture, allowing comparison with other avenues for page reload (e.g., from toolbar reload icon). BUG=442505 Committed: https://crrev.com/07e2788ed69fa76cb427884ea8f05807fd6a1806 Cr-Commit-Position: refs/heads/master@{#308477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/android/overscroll_controller_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/actions/extract_actions.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jdduke (slow)
tedcho@: I've never used the "UserMetricsAction" construct (have always used the histogram macros directly), just ...
6 years ago (2014-12-15 23:00:23 UTC) #2
Ted C
lgtm
6 years ago (2014-12-15 23:02:37 UTC) #3
jdduke (slow)
+isherman@ for tools/metrics/actions review.
6 years ago (2014-12-15 23:56:33 UTC) #5
Ilya Sherman
metrics lgtm
6 years ago (2014-12-16 00:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803343002/1
6 years ago (2014-12-16 00:39:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 00:45:25 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 00:46:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07e2788ed69fa76cb427884ea8f05807fd6a1806
Cr-Commit-Position: refs/heads/master@{#308477}

Powered by Google App Engine
This is Rietveld 408576698