Fix special character handling in audio preferences.

Fix special character handling in audio preferences.

This CL fixes the handling of the "." character in device names for audio
preferences. It also adds unit tests for the preference handler.

R=jennyz@chromium.org
BUG=294488, 431133
Committed: https://crrev.com/e0a1ab0bf2b065109182e9ddacbbca02e57e9631
Cr-Commit-Position: refs/heads/master@{#308460}

[jennyz, 2014-12-15 22:34:07]

lgtm with nits.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
File chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc
(right):

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:1: //
Copyright (c) 2013 The Chromium Authors. All rights reserved.
nit: no (c) with new code guideline. 2013->2014.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:68:
virtual ~AudioDevicesPrefHandlerTest() {}
no virtual, just override by new code guideline.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:70:
virtual void SetUp() override {
Nit. no more virtual by code guide line.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:76:
virtual void TearDown() override { audio_pref_handler_ = NULL; }
ditto

[rkc, 2014-12-15 22:44:43]

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
File chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc
(right):

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:1: //
Copyright (c) 2013 The Chromium Authors. All rights reserved.
On 2014/12/15 22:34:06, jennyz wrote:
> nit: no (c) with new code guideline. 2013->2014.

Done.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:68:
virtual ~AudioDevicesPrefHandlerTest() {}
On 2014/12/15 22:34:07, jennyz wrote:
> no virtual, just override by new code guideline.

Done.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:70:
virtual void SetUp() override {
On 2014/12/15 22:34:07, jennyz wrote:
> Nit. no more virtual by code guide line.

Done.

https://codereview.chromium.org/803303002/diff/1/chrome/browser/chromeos/audi...
chrome/browser/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc:76:
virtual void TearDown() override { audio_pref_handler_ = NULL; }
On 2014/12/15 22:34:07, jennyz wrote:
> ditto

Done.

[rkc, 2014-12-15 22:44:48]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2014-12-15 22:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803303002/20001

[commit-bot: I haz the power, 2014-12-15 23:45:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-15 23:46:07]

Patchset 2 (id:??) landed as
https://crrev.com/e0a1ab0bf2b065109182e9ddacbbca02e57e9631
Cr-Commit-Position: refs/heads/master@{#308460}