Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 803293002: Add native_test_native_code dependency for ui_touch_selection_unittests (Closed)

Created:
6 years ago by jdduke (slow)
Modified:
6 years ago
CC:
chromium-reviews, mohsen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add native_test_native_code dependency for ui_touch_selection_unittests This is required for running the tests as a standalone APK. BUG=441187 Committed: https://crrev.com/bcdca4eb6b38b420ebd0fdb3d36068fd065917e3 Cr-Commit-Position: refs/heads/master@{#308449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/touch_selection/ui_touch_selection.gyp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
aurimas@: PTAL, thanks.
6 years ago (2014-12-15 22:09:45 UTC) #2
aurimas (slooooooooow)
lgtm
6 years ago (2014-12-15 22:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803293002/1
6 years ago (2014-12-15 22:11:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 23:14:43 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 23:15:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcdca4eb6b38b420ebd0fdb3d36068fd065917e3
Cr-Commit-Position: refs/heads/master@{#308449}

Powered by Google App Engine
This is Rietveld 408576698