Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803283006: Add a fps-counter widget to some Sky demos (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a fps-counter widget to some Sky demos This CL makes some Sky demos more interesting and adds an fps-widget to see how fast they run. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1557f5e11549a35d8ec84ebb470727ba1499b40

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -5 lines) Patch
A sky/examples/fps-counter.sky View 1 chunk +64 lines, -0 lines 0 comments Download
M sky/examples/spinning-square.sky View 2 chunks +3 lines, -1 line 0 comments Download
M sky/examples/touch-demo.sky View 2 chunks +25 lines, -4 lines 3 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-14 23:42:43 UTC) #1
esprehn
lgtm https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky File sky/examples/touch-demo.sky (right): https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky#newcode37 sky/examples/touch-demo.sky:37: s typo
5 years, 11 months ago (2015-01-14 23:48:54 UTC) #2
abarth-chromium
Committed patchset #1 (id:1) manually as c1557f5e11549a35d8ec84ebb470727ba1499b40 (presubmit successful).
5 years, 11 months ago (2015-01-14 23:51:04 UTC) #3
ojan
https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky File sky/examples/touch-demo.sky (right): https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky#newcode13 sky/examples/touch-demo.sky:13: <x-fps-counter /> Does this work? Shouldn't this just be ...
5 years, 11 months ago (2015-01-15 18:54:57 UTC) #5
abarth-chromium
5 years, 11 months ago (2015-01-15 19:09:39 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky
File sky/examples/touch-demo.sky (right):

https://codereview.chromium.org/803283006/diff/1/sky/examples/touch-demo.sky#...
sky/examples/touch-demo.sky:13: <x-fps-counter />
On 2015/01/15 at 18:54:57, ojan wrote:
> Does this work? Shouldn't this just be fps-counter?

Oops.  We did this to comment it out.  I'll add it back.

Powered by Google App Engine
This is Rietveld 408576698