Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Unified Diff: client/crashpad_info.h

Issue 803283002: win: Avoid 'warning C4068: unknown pragma' (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@cxx-lib-version
Patch Set: blank lines for clarity Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_info.h
diff --git a/client/crashpad_info.h b/client/crashpad_info.h
index 27ad12927e2bbfd058fb61524c44d288935d71c2..86afff13a61a77b78a4e8abe0ff5a3c42b2458f3 100644
--- a/client/crashpad_info.h
+++ b/client/crashpad_info.h
@@ -48,15 +48,21 @@ struct CrashpadInfo {
// shouldn’t warn about that. These fields aren’t intended for use by the
// process they’re found in, they’re supposed to be read by the crash
// reporting process.
+#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-private-field"
+#endif
+
// Fields present in version 1:
uint32_t signature_; // kSignature
uint32_t size_; // The size of the entire CrashpadInfo structure.
uint32_t version_; // kVersion
uint32_t padding_0_;
SimpleStringDictionary* simple_annotations_; // weak
+
+#if defined(__clang__)
#pragma clang diagnostic pop
+#endif
DISALLOW_COPY_AND_ASSIGN(CrashpadInfo);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698