win: Avoid 'warning C4068: unknown pragma'

win: Avoid 'warning C4068: unknown pragma'

I could also add COMPILER_CLANG to build_config.h, but that doesn't
appear in Chromium, apparently in preference to using __clang__
directly. I'm not sure if there's any good reason for that.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e8ab9afd82396d856cae24db04eddf8c4e939c44

[Mark Mentovai, 2014-12-15 23:36:15]

LGTM

https://codereview.chromium.org/803283002/diff/1/client/crashpad_info.h
File client/crashpad_info.h (right):

https://codereview.chromium.org/803283002/diff/1/client/crashpad_info.h#newco...
client/crashpad_info.h:47: // The compiler won’t necessarily see anyone using
these fields, but it
This comment conceptually belongs with the pragmas, but it’s a little isolated
in long run of stuff. I think a couple of blanks could help, like:

  // comment
#if …
#pragma …
#endif
                // new blank line
  // Fields present
  blah;
                // new blank line
#if …
#pragma …
#endif

[scottmg, 2014-12-15 23:40:58]

https://codereview.chromium.org/803283002/diff/1/client/crashpad_info.h
File client/crashpad_info.h (right):

https://codereview.chromium.org/803283002/diff/1/client/crashpad_info.h#newco...
client/crashpad_info.h:47: // The compiler won’t necessarily see anyone using
these fields, but it
On 2014/12/15 23:36:15, Mark Mentovai wrote:
> This comment conceptually belongs with the pragmas, but it’s a little isolated
> in long run of stuff. I think a couple of blanks could help, like:
> 
>   // comment
> #if …
> #pragma …
> #endif
>                 // new blank line
>   // Fields present
>   blah;
>                 // new blank line
> #if …
> #pragma …
> #endif

Done.

[scottmg, 2014-12-15 23:59:43]

Patchset #2 (id:20001) has been deleted

[scottmg, 2014-12-16 00:00:54]

Patchset #2 (id:40001) has been deleted

[scottmg, 2014-12-16 00:01:20]

Committed patchset #2 (id:60001) manually as
e8ab9afd82396d856cae24db04eddf8c4e939c44 (presubmit successful).