Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7594)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 80323002: Restores maximized browser before dragging a tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restores maximized browser before dragging a tab (rebase) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
index 6dd4a514e7c2a10c9c90421ae49af0243e604c97..e51f397d653210a6daaa236763c239475e11e6bd 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
@@ -2150,15 +2150,18 @@ IN_PROC_BROWSER_TEST_P(DetachToDockedTabDragControllerTest,
EXPECT_TRUE(IsWindowPositionManaged(
new_browser->window()->GetNativeWindow()));
- // The new window should be docked and not maximized if docking is allowed.
ash::wm::WindowState* window_state =
ash::wm::GetWindowState(new_browser->window()->GetNativeWindow());
+ // The new window should not be maximized because it gets docked or snapped.
+ EXPECT_FALSE(new_browser->window()->IsMaximized());
if (docked_windows_enabled()) {
- EXPECT_FALSE(new_browser->window()->IsMaximized());
+ // The new window should be docked and not snapped if docking is allowed.
EXPECT_TRUE(window_state->IsDocked());
+ EXPECT_FALSE(window_state->IsSnapped());
} else {
- EXPECT_TRUE(new_browser->window()->IsMaximized());
+ // The new window should be snapped and not docked if docking is disabled.
EXPECT_FALSE(window_state->IsDocked());
+ EXPECT_TRUE(window_state->IsSnapped());
}
}
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698