Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp

Issue 803213004: [New Multicolumn] Handle overflow inside spanners correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code review Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/multicol/span/overflow-on-viewport-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp
diff --git a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp
index b0555a5b2af6c9766a4a282382d2e39e16ee7c6e..169146bfc2519ed72f58ca137b3a70247902da0b 100644
--- a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp
+++ b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp
@@ -55,6 +55,12 @@ void RenderMultiColumnSpannerPlaceholder::layout()
// height as well, so that we take up the correct amount of space in the multicol container.
updateLogicalHeight();
+ // Take the overflow from the spanner, so that it gets
+ // propagated to the multicol container and beyond.
+ m_overflow.clear();
+ addVisualOverflow(m_rendererInFlowThread->visualOverflowRect());
+ addLayoutOverflow(m_rendererInFlowThread->layoutOverflowRect());
+
clearNeedsLayout();
}
« no previous file with comments | « LayoutTests/fast/multicol/span/overflow-on-viewport-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698