LayoutTests/fast/multicol/span/overflow-on-viewport.html - Issue 803213004: [New Multicolumn] Handle overflow inside spanners correctly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/overflow-on-viewport.html

Issue 803213004: [New Multicolumn] Handle overflow inside spanners correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/span/overflow-on-multicol-expected.html ('k') | LayoutTests/fast/multicol/span/overflow-on-viewport-expected.html » ('j') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 onload = function() {

	4 document.documentElement.scrollTop = 10000;

	5 }

	6 </script>

	7 <p style="position:fixed;">You should see the word 'PASS' below.</p>
	Julien - ping for review 2015/01/20 14:07:38 Again I would like to see a description of what Again I would like to see a description of what you're testing in these tests. That makes it easier to triage a potential regression as well as help people reading the test to understand the intent. mstensho (USE GERRIT) 2015/01/20 16:31:56 Done. Show quoted text On 2015/01/20 14:07:38, Julien Chaffraix - CET wrote: > Again I would like to see a description of what you're testing in these tests. > That makes it easier to triage a potential regression as well as help people > reading the test to understand the intent. Done.
	8 <div style="height:4em; -webkit-columns:4;">

	9 <div style="-webkit-column-span:all; height:2em;">

	10 <div style="height:200vh;"></div>

	11 PASS

	12 </div>

	13 </div>

OLD	NEW