Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803213003: fix end-point and conic bugs in cornerpatheffect (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix end-point and conic bugs in cornerpatheffect fixes bug in GM/patheffect -- will need to be rebaselined BUG=skia: Committed: https://skia.googlesource.com/skia/+/2b9445b84e64a122676b65637d40cb31f5437c17

Patch Set 1 #

Patch Set 2 : add suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
6 years ago (2014-12-16 22:17:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803213003/20001
6 years ago (2014-12-16 22:22:49 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-16 22:22:50 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years ago (2014-12-17 04:22:57 UTC) #7
caryclark
lgtm
6 years ago (2014-12-17 12:34:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803213003/20001
6 years ago (2014-12-17 13:47:10 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-17 13:50:59 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2b9445b84e64a122676b65637d40cb31f5437c17

Powered by Google App Engine
This is Rietveld 408576698