Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 803183006: Tweak style of AudioListener doppler deprecations (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Raymond Toy
CC:
blink-reviews, Raymond Toy
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Tweak style of AudioListener doppler deprecations None of the other existing Deprecated* are actually deprecated and none of the other currently deprecated features are named Deprecated*. Use the InterfaceAttributeOrFunction naming convention instead. Also, extra blank lines in UseCounter.h has caused trouble: https://codereview.chromium.org/729393002/#msg19 BUG=439644 TBR=rtoy@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioListener.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803183006/1
6 years ago (2014-12-16 09:47:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187245
6 years ago (2014-12-16 12:18:54 UTC) #3
Raymond Toy
6 years ago (2014-12-16 16:36:38 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698