third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp - Issue 803133002: Use invalidation sets for fullscreen pseudos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp

Issue 803133002: Use invalidation sets for fullscreen pseudos. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Load fullscreen.css on demand Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp b/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp

index 18ba58984796f5d3acb34b5da28ad571275c78ab..24758d9950625ff98168b1b123620e30210467cd 100644

--- a/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp

+++ b/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp

@@ -165,20 +165,21 @@ void CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement(const Element& el

changedDefaultStyle = true;

}

- // FIXME: This only works because we Force recalc the entire document so the new sheet

- // is loaded for <html> and the correct styles apply to everyone.

- if (!m_fullscreenStyleSheet && Fullscreen::isFullScreen(element.document())) {

- String fullscreenRules = loadResourceAsASCIIString("fullscreen.css") + LayoutTheme::theme().extraFullScreenStyleSheet();

- m_fullscreenStyleSheet = parseUASheet(fullscreenRules);

- m_defaultStyle->addRulesFromSheet(fullscreenStyleSheet(), screenEval());

- m_defaultQuirksStyle->addRulesFromSheet(fullscreenStyleSheet(), screenEval());

- changedDefaultStyle = true;

- }

ASSERT(!m_defaultStyle->features().hasIdsInSelectors());

ASSERT(m_defaultStyle->features().siblingRules.isEmpty());

}

+void CSSDefaultStyleSheets::ensureDefaultStyleSheetForFullscreen()

+ if (m_fullscreenStyleSheet)

+ return;

+ String fullscreenRules = loadResourceAsASCIIString("fullscreen.css") + LayoutTheme::theme().extraFullScreenStyleSheet();

+ m_fullscreenStyleSheet = parseUASheet(fullscreenRules);

+ m_defaultStyle->addRulesFromSheet(fullscreenStyleSheet(), screenEval());

+ m_defaultQuirksStyle->addRulesFromSheet(fullscreenStyleSheet(), screenEval());

DEFINE_TRACE(CSSDefaultStyleSheets)

{

visitor->trace(m_defaultStyle);