Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 803113003: Silence warnings from libnanomsg on Mac like we do on Linux. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Silence warnings from libnanomsg on Mac like we do on Linux. This will silence these warnings: ../../third_party/externals/nanomsg/src/core/global.c:162:34: warning: missing field 'unused' initializer [-Wmissing-field-initializers] static struct nn_global self = {0}; ../../third_party/externals/nanomsg/src/utils/clock.c:44:61: warning: missing field 'denom' initializer [-Wmissing-field-initializers] static mach_timebase_info_data_t nn_clock_timebase_info = {0}; BUG=skia: Committed: https://skia.googlesource.com/skia/+/c97570cfb38a90ad36b4dce1ca82e809d3fb9ef0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gyp/nanomsg.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years ago (2014-12-15 20:09:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803113003/1
6 years ago (2014-12-15 20:09:56 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-15 20:09:57 UTC) #5
caryclark
lgtm
6 years ago (2014-12-15 20:10:47 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 20:24:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c97570cfb38a90ad36b4dce1ca82e809d3fb9ef0

Powered by Google App Engine
This is Rietveld 408576698