content/renderer/manifest/manifest_parser.h - Issue 803063003: Fix crash when passing temporary variable as document/manifest URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_parser.h

Issue 803063003: Fix crash when passing temporary variable as document/manifest URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/manifest/manifest_parser.h

diff --git a/content/renderer/manifest/manifest_parser.h b/content/renderer/manifest/manifest_parser.h

index 94b7e025db8321eb99191548c7f98338147f2eaa..13e330b0ddbb18ca0cc78dcc98199d027f290015 100644

--- a/content/renderer/manifest/manifest_parser.h

+++ b/content/renderer/manifest/manifest_parser.h

@@ -136,8 +136,8 @@ class CONTENT_EXPORT ManifestParser {

bool ParseGCMUserVisibleOnly(const base::DictionaryValue& dictionary);

const base::StringPiece& data_;

- const GURL& manifest_url_;

- const GURL& document_url_;

+ GURL manifest_url_;

+ GURL document_url_;

bool failed_;

Manifest manifest_;

« no previous file with comments | « no previous file | content/renderer/manifest/manifest_parser_unittest.cc » ('j') | no next file with comments »