Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: src/serialize.cc

Issue 803063002: Add a CHECK to make sure we don't accidentally serialize type feedback (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/serialize.h ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/serialize.cc
diff --git a/src/serialize.cc b/src/serialize.cc
index 01c55a1226efedc5cca0d8bc1f80ad99dede6ba4..d58d8e200f04abd7c74abb20a2ecc7a10736a490 100644
--- a/src/serialize.cc
+++ b/src/serialize.cc
@@ -1307,14 +1307,16 @@ void Deserializer::ReadData(Object** current, Object** limit, int source_space,
}
-Serializer::Serializer(Isolate* isolate, SnapshotByteSink* sink)
+Serializer::Serializer(Isolate* isolate, SnapshotByteSink* sink,
+ bool allow_type_feedback)
: isolate_(isolate),
sink_(sink),
external_reference_encoder_(new ExternalReferenceEncoder(isolate)),
root_index_map_(isolate),
code_address_map_(NULL),
large_objects_total_size_(0),
- seen_large_objects_index_(0) {
+ seen_large_objects_index_(0),
+ allow_type_feedback_(allow_type_feedback) {
// The serializer is meant to be used only to generate initial heap images
// from a context in which there is only one isolate.
for (int i = 0; i < kNumberOfPreallocatedSpaces; i++) {
@@ -1768,6 +1770,12 @@ void Serializer::ObjectSerializer::Serialize() {
}
}
+ if (object_->IsSharedFunctionInfo() && !serializer_->allow_type_feedback_) {
+ CHECK(SharedFunctionInfo::cast(object_)
+ ->feedback_vector()
+ ->CanBeSerialized());
+ }
+
int size = object_->Size();
Map* map = object_->map();
SerializePrologue(Serializer::SpaceOfObject(object_), size, map);
« no previous file with comments | « src/serialize.h ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698