Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 802983004: Revert of Suppress uninitialized read in drmemory bot (Closed)

Created:
6 years ago by zhaoqin1
Modified:
6 years ago
Reviewers:
oshima, mdempsky
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress uninitialized read in drmemory bot (patchset #1 id:1 of https://codereview.chromium.org/802983003/) Reason for revert: The suppression will suppress almost all errors, and make Dr.Memory bots useless. The bad callstack is caused by the VS producing corrupted pdb, clobber to builder. Original issue's description: > Suppress uninitialized read in drmemory bot > > BUG=442850 > TBR=mdempsky@chromium.org > NOTRY=true > > Committed: https://crrev.com/2a589da939ba026ff87559885c1dc17ed236f89d > Cr-Commit-Position: refs/heads/master@{#308648} TBR=mdempsky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=442850 Committed: https://crrev.com/81a60d83a974b054b6578b45986eafc52f84da50 Cr-Commit-Position: refs/heads/master@{#308657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zhaoqin1
Created Revert of Suppress uninitialized read in drmemory bot
6 years ago (2014-12-16 20:20:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802983004/1
6 years ago (2014-12-16 20:20:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 20:22:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81a60d83a974b054b6578b45986eafc52f84da50 Cr-Commit-Position: refs/heads/master@{#308657}
6 years ago (2014-12-16 20:22:54 UTC) #4
mdempsky
6 years ago (2014-12-16 20:33:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698