Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802983003: Suppress uninitialized read in drmemory bot (Closed)

Created:
6 years ago by oshima
Modified:
6 years ago
Reviewers:
mdempsky
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress uninitialized read in drmemory bot BUG=442850 TBR=mdempsky@chromium.org NOTRY=true Committed: https://crrev.com/2a589da939ba026ff87559885c1dc17ed236f89d Cr-Commit-Position: refs/heads/master@{#308648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
oshima
6 years ago (2014-12-16 19:59:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802983003/1
6 years ago (2014-12-16 20:01:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 20:02:08 UTC) #4
mdempsky
lgtm, but I don't know anything about drmemory
6 years ago (2014-12-16 20:02:54 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2a589da939ba026ff87559885c1dc17ed236f89d Cr-Commit-Position: refs/heads/master@{#308648}
6 years ago (2014-12-16 20:02:58 UTC) #6
zhaoqin1
6 years ago (2014-12-16 20:20:39 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/802983004/ by zhaoqin@chromium.org.

The reason for reverting is: The suppression will suppress almost all errors,
and make Dr.Memory bots useless.
The bad callstack is caused by the VS producing corrupted pdb, clobber to
builder..

Powered by Google App Engine
This is Rietveld 408576698