Issue 802923003: Revert of Report PasswordManager.OsPasswordStatus on a background thread with a delay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 802923003: Revert of Report PasswordManager.OsPasswordStatus on a background thread with a delay. (Closed)

Created:
6 years ago by grt (UTC plus 2)

Modified:
6 years ago

Reviewers:
vabr (Chromium), vasilii

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, Will Harris, grt (UTC plus 2)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Report PasswordManager.OsPasswordStatus on a background thread with a delay. (patchset #1 id:1 of https://codereview.chromium.org/800723004/) Reason for revert: Reverting because DCHECK is hit 40s after startup. Original issue's description: > Report PasswordManager.OsPasswordStatus on a background thread with a delay. > > The histogram was revived in https://codereview.chromium.org/772413004/ but caused jankiness on the UI thread. > > BUG=441428 > > Committed: https://crrev.com/08cd707154a8b1ca7869c5b410d98acb8a6ed3e7 > Cr-Commit-Position: refs/heads/master@{#308128} TBR=vabr@chromium.org,vasilii@chromium.org NOTREECHECKS=true NOTRY=true BUG=441428 Committed: https://crrev.com/d2dfcfe8041f3cbba31419448963080fa3fb1ded Cr-Commit-Position: refs/heads/master@{#308619}

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -25 lines)			Patch
	M	chrome/browser/password_manager/chrome_password_manager_client.cc	View		2 chunks	+19 lines, -0 lines	0 comments	Download
	M	chrome/browser/password_manager/password_store_factory.cc	View		3 chunks	+2 lines, -25 lines	0 comments	Download

Total messages: 4 (0 generated)

grt (UTC plus 2)

Created Revert of Report PasswordManager.OsPasswordStatus on a background thread with a delay.

6 years ago (2014-12-16 18:28:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802923003/1

6 years ago (2014-12-16 18:29:57 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-16 18:32:56 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d2dfcfe8041f3cbba31419448963080fa3fb1ded
Cr-Commit-Position: refs/heads/master@{#308619}