Chromium Code Reviews
Help | Chromium Project | Sign in
(268)

Issue 8029001: check_licenses, plan B: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Paweł Hajdan Jr.
Modified:
3 years, 10 months ago
Reviewers:
cmp, Nicolas Sylvain
CC:
chromium-reviews, James Simonsen
Visibility:
Public.

Description

check_licenses, plan B: - don't run check_licenses on fast builders - only run it on already slow Linux clobber builder - don't run it on trybots but default, but make it optional - remove it from LKGR for now, to avoid making it stale - check_licenses are _not_ going to be run on CQ for consistency with trybots BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M masters/master.chromium.lkgr/lkgr_finder.py View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.chromium/master_full_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium/master_linux_cfg.py View 2 chunks +1 line, -2 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 chunk +5 lines, -1 line 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: Nicolas: everything John (CC-ed, FYI)
3 years, 10 months ago (2011-09-23 20:29:54 UTC) #1
Paweł Hajdan Jr.
+Chase, not sure if Nicolas is around, and this should land today
3 years, 10 months ago (2011-09-23 21:31:36 UTC) #2
cmp
3 years, 10 months ago (2011-09-23 21:33:16 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f