Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802863002: Change <!DOCTYPE> to <!doctype>. (Closed)

Created:
6 years ago by Dan Beam
Modified:
6 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, benjhayden+dwatch_chromium.org, dzhioev+watch_chromium.org, Patrick Dubroy, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, nhiroki, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, tfarina, donnd+watch_chromium.org, eroman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, kinuko+fileapi, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change <!DOCTYPE> to <!doctype>. Frankly I'm tired of all the inconsistencies and <!DOCTYPE> looks odd being the only tag-like thing on the page that's UPPERCASE. It Officially Doesn't Matter according to the HTML5 spec: http://www.w3.org/TR/html5/syntax.html#the-doctype R=estade@chromium.org BUG=none TEST=less annoyance Committed: https://crrev.com/a3992d3f39b7126eea3405fe44912989378aaa15 Cr-Commit-Position: refs/heads/master@{#308249}

Patch Set 1 : splitting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -109 lines) Patch
M chrome/browser/resources/about_conflicts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_credits.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_flash.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_invalidations.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_nacl.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_stats.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_sys/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_voicesearch.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/app_list/start_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/certificate_viewer.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/about_os_credits.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/bluetooth_pair_device.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/certificate_manager_dialog.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/choose_mobile_network.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/cryptohome.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/guest_session_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/image_burner.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_context_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/merge_session_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup_portal.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/nfc_debug.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_app_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/offline_net_load.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/power.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/salsa.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/set_time.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/slow.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/components.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/contextual_search/promo.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/crashes.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/domain_reliability_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/downloads/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_info.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_load_error.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/html/default.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/flags.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/offline.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/success.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/gcm_internals.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/gesture_config.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/help/help.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history/history.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/identity_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/inline_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/new_inline_login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/instant/instant.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_title.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/local_state/local_state.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media/webrtc_logs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/memory_internals/memory_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_export/net_export.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/notification_1line.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/notification_2line.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/notification_icon.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/guest_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/incognito_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/omnibox/omnibox.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/password_manager_internals/password_manager_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/policy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/predictors/predictors.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/profile_signin_confirmation.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/profiler/profiler.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/quota_internals/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/reader_out_of_date.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/set_as_default_browser.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/signin_internals/signin_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/suggestions_internals/suggestions_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/supervised_user_block_interstitial.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_file_system_internals/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/user_actions/user_actions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/user_manager/user_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/whispernet_proxy/background.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/menu_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Dan Beam
6 years ago (2014-12-13 02:01:46 UTC) #1
Evan Stade
lgtm
6 years ago (2014-12-13 02:05:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802863002/40001
6 years ago (2014-12-13 02:08:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years ago (2014-12-13 04:04:56 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-13 04:06:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a3992d3f39b7126eea3405fe44912989378aaa15
Cr-Commit-Position: refs/heads/master@{#308249}

Powered by Google App Engine
This is Rietveld 408576698