Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: Source/core/rendering/svg/SVGRenderingContext.cpp

Issue 802833003: Remove the SVG paint culling optimization (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix test for the moon lander. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/svg/SVGRenderSupport.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 // Return with false here may mean that we don't need to draw the co ntent 157 // Return with false here may mean that we don't need to draw the co ntent
158 // (because it was either drawn before or empty) but we still need t o apply the filter. 158 // (because it was either drawn before or empty) but we still need t o apply the filter.
159 m_renderingFlags |= PostApplyResources; 159 m_renderingFlags |= PostApplyResources;
160 if (!m_filter->prepareEffect(m_object, m_paintInfo->context)) 160 if (!m_filter->prepareEffect(m_object, m_paintInfo->context))
161 return; 161 return;
162 162
163 // Since we're caching the resulting bitmap and do not invalidate it on paint invalidation rect 163 // Since we're caching the resulting bitmap and do not invalidate it on paint invalidation rect
164 // changes, we need to paint the whole filter region. Otherwise, ele ments not visible 164 // changes, we need to paint the whole filter region. Otherwise, ele ments not visible
165 // at the time of the initial paint (due to scrolling, window size, etc.) will never 165 // at the time of the initial paint (due to scrolling, window size, etc.) will never
166 // be drawn. 166 // be drawn.
167 m_paintInfo->rect = IntRect(m_filter->drawingRegion(m_object)); 167 m_paintInfo->rect = LayoutRect::infiniteIntRect();
168 } 168 }
169 } else { 169 } else {
170 // Broken filter disables rendering. 170 // Broken filter disables rendering.
171 if (svgStyle.hasFilter()) 171 if (svgStyle.hasFilter())
172 return; 172 return;
173 } 173 }
174 174
175 if (!isIsolationInstalled() && SVGRenderSupport::isIsolationRequired(object) ) { 175 if (!isIsolationInstalled() && SVGRenderSupport::isIsolationRequired(object) ) {
176 m_paintInfo->context->beginTransparencyLayer(1); 176 m_paintInfo->context->beginTransparencyLayer(1);
177 m_renderingFlags |= EndOpacityLayer; 177 m_renderingFlags |= EndOpacityLayer;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 { 255 {
256 ASSERT(context); 256 ASSERT(context);
257 ASSERT(item); 257 ASSERT(item);
258 ASSERT(!item->needsLayout()); 258 ASSERT(!item->needsLayout());
259 259
260 PaintInfo info(context, LayoutRect::infiniteIntRect(), PaintPhaseForeground, PaintBehaviorNormal); 260 PaintInfo info(context, LayoutRect::infiniteIntRect(), PaintPhaseForeground, PaintBehaviorNormal);
261 item->paint(info, IntPoint()); 261 item->paint(info, IntPoint());
262 } 262 }
263 263
264 } // namespace blink 264 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/SVGRenderSupport.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698