Chromecast: media interfaces for hardware-backed video plane.

chromecast/media/cma/backend/video_plane.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PLANE_H_
+#define CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PLANE_H_
+
+#include "base/macros.h"
+
+namespace gfx {
+class QuadF;
+class Size;
+}
+
+namespace chromecast {
+namespace media {
+
+class VideoPlane {
+ public:
+  enum CoordinateType {
+    // Graphics plane as coordinate type.
+    COORDINATE_TYPE_GRAPHICS_PLANE = 0,

[damienv1, 2014/12/13 01:51:00]

nit: blank line

[gunsch, 2014/12/13 02:01:29]

Done.

+    // Output display screen as coordinate type.
+    COORDINATE_TYPE_SCREEN_RESOLUTION = 1,

[damienv1, 2014/12/13 01:51:00]

Should be renamed to COORDINATE_TYPE_VIDEO_PLANE_RESOLUTION if the intent is to
give coordinates using video plane resolution (which I think it is).

I know that for Eureka, currently, video plane resolution == screen resolution
but it does not have to.

[gunsch, 2014/12/13 02:01:29]

Done.

+  };
+
+ public:

[damienv1, 2014/12/13 01:51:00]

nit: not needed, already in the public section...

[gunsch, 2014/12/13 02:01:29]

Done.

+  VideoPlane();
+  virtual ~VideoPlane();
+
+  // Gets output screen resolution.
+  virtual gfx::Size GetScreenResolution() = 0;

[damienv1, 2014/12/13 01:51:00]

Either remove this function (if the intent is to get the screen resolution) or
rename it to GetVideoPlaneResolution()

[gunsch, 2014/12/13 02:01:29]

Done.

+
+  // Updates the video plane geometry.
+  // |quad.p1()| corresponds to the top left of the original video,
+  // |quad.p2()| to the top right of the original video,
+  // and so on.
+  // Depending on the underlying hardware, the exact geometry
+  // might not be honored.
+  // |coordinate_type| indicates what coordinate type |quad| refers to.
+  virtual void SetGeometry(const gfx::QuadF& quad,
+                           CoordinateType coordinate_type) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(VideoPlane);
+};
+
+// Global accessor to the video plane.
+VideoPlane* GetVideoPlane();
+
+}  // namespace media
+}  // namespace chromecast
+
+#endif  // CHROMECAST_MEDIA_CMA_BACKEND_VIDEO_PLANE_H_