Skip PositionedMovementLayout when descendants depend on element's height

Source/core/rendering/RenderBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 3860 matching lines @@
 
     LayoutUnit oldClientAfterEdge = hasRenderOverflow() ? m_overflow->layoutClientAfterEdge() : clientLogicalBottom();
     computeOverflow(oldClientAfterEdge, true);
 
     if (hasOverflowClip())
         layer()->scrollableArea()->updateAfterOverflowRecalc();
 
     return !hasOverflowClip();
 }
 
+// Called when a positioned object moves but doesn't necessarily change size.  A simplified layout is attempted
+// that just updates the object's position. If the size does change, the object remains dirty.
+bool RenderBlock::tryLayoutDoingPositionedMovementOnly()

[Julien - ping for review, 2015/01/06 14:35:09]

I can understand why only blocks use this function, however boxes can be
positioned (e.g. table row / row group) so it made sense for the function to be
on RenderBox. Combined with the history churn, I would argue to leave the
function on RenderBox.

[rhogan, 2015/01/06 21:43:45]

The other reason I moved it is that hasPercentageHeightDescendants() is
RenderBlock-only. I think the two together make it right to move. What do you
think?

[Julien - ping for review, 2015/01/07 09:41:39]

I think we have no other option then as hasPercentageHeightDescendants() only
makes sense for RenderBlocks (it's only meaningful for containing blocks). What
that means is that positioned movement only is a block concept then, which we
are probably fine with.

+{
+    LayoutUnit oldWidth = logicalWidth();
+    LogicalExtentComputedValues computedValues;
+    logicalExtentAfterUpdatingLogicalWidth(logicalTop(), computedValues);
+    // If we shrink to fit our width may have changed, so we still need full layout.
+    if (oldWidth != computedValues.m_extent)
+        return false;
+    setLogicalWidth(computedValues.m_extent);
+    setLogicalLeft(computedValues.m_position);
+    setMarginStart(computedValues.m_margins.m_start);
+    setMarginEnd(computedValues.m_margins.m_end);
+
+    LayoutUnit oldHeight = logicalHeight();
+    updateLogicalHeight();
+    if (hasPercentHeightDescendants() && oldHeight != logicalHeight())

[Julien - ping for review, 2015/01/06 14:35:09]

The percentage height descendant map is filled during full layout but I think it
works to use it here as we should do a full layout when it is dirtied.

+        return false;
+    return true;

[Julien - ping for review, 2015/01/06 14:35:09]

The past 3 lines can be combined into a single line, which I find more readable.
If needed you can add a comment that we only care about the logical height if we
have percentage height descendants.

return !hasPercentHeightDescendant() || oldHeight == logicalHeight();

+}
+
 #if ENABLE(ASSERT)
 void RenderBlock::checkPositionedObjectsNeedLayout()
 {
     if (!gPositionedDescendantsMap)
         return;
 
     if (TrackedRendererListHashSet* positionedDescendantSet = positionedObjects()) {
         TrackedRendererListHashSet::const_iterator end = positionedDescendantSet->end();
         for (TrackedRendererListHashSet::const_iterator it = positionedDescendantSet->begin(); it != end; ++it) {
             RenderBox* currBox = *it;
@@ skipping 22 matching lines @@
 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* markedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const RenderObject* obj) const
 {
     showRenderObject();
     for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRootBox())
         root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLabel2, obj, 1);
 }
 
 #endif
 
 } // namespace blink