LayoutTests/fast/block/positioning/positioned-movement-layout-when-height-changes-and-positioned-descendant-dependent-on-height.html - Issue 802813003: Skip PositionedMovementLayout when descendants depend on element's height

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/positioning/positioned-movement-layout-when-height-changes-and-positioned-descendant-dependent-on-height.html

Issue 802813003: Skip PositionedMovementLayout when descendants depend on element's height (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <style>

	3 body {

	4 margin: 0;

	5 }

	6 #container {

	7 position: absolute;

	8 height: 154px;

	9 width: 20px;

	10 overflow: hidden;

	11 background-color: blue;

	12 }

	13 #test {

	14 position: absolute;

	15 top: 0px;

	16 bottom: 0px;

	17 left: 0px;

	18 right: 0px;

	19 height: auto;

	20 }

	21 .contents {

	22 position: absolute;

	23 background-color: green;

	24 top: 0px;

	25 bottom: 0px;

	26 left: 0px;

	27 right: 0px;

	28 height: auto;

	29 }

	30 </style>

	31 <script>

	32

	33 function runTest()

	34 {

	35 var test = document.getElementById('test');

	36 document.body.offsetTop;

	37 test.style['top'] = '20px';

	38 test.style['bottom'] = '20px';

	39 }

	40 window.onload = runTest;

	41 </script>

	42 <div id="top">
	Julien - ping for review 2015/01/06 14:35:09 #top is unused in both test cases. #top is unused in both test cases.
	43 <div id="container">

	44 <div id="test">

	45 <div class="contents"></div>

	46 </div>

	47 </div>

	48 </div>

	49 Tests positioned movement layout when its height has changed and a descendant de pends on its height.
	Julien - ping for review 2015/01/06 14:35:09 You forgot to put the visual condition for passing You forgot to put the visual condition for passing in both tests. OR Those tests looks like they could be check-layout.js test by testing the offset top and height.
OLD	NEW